Fix #17397: Fully export instrument changes to MusicXML #24932
+150
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2024
Backport of musescore#24932 and fixing some clang watnings
| } | ||
| m_xml.endElement(); | ||
|
|
||
| writeInstrumentDetails(instrChange->instrument(), m_score->style().styleB(Sid::concertPitch)); |
There was a problem hiding this comment.
Why not using instr here too, like a few lines down?
There was a problem hiding this comment.
Thanks for your review! Actually found another thing that lead to invalid MusicXML output. Fixed that one, too.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2024
Backport of musescore#24932 and enable and fix testMultiInstrumentPart3. Also fixing some clang warnings.
rettinghaus
force-pushed
the
xml/instrChange
branch
from
5fa298c
to
744d4d2
Compare
| const int instNr = muse::value(m_instrMap, instr, -1); | ||
| const string longName = instr->nameAsPlainText(); | ||
| const string shortName = instr->abbreviatureAsPlainText(); | ||
| static const std::wregex acc(L"[♭♯]"); |
rettinghaus
force-pushed
the
xml/instrChange
branch
from
33dc07d
to
d6b1fb6
Compare
rettinghaus
force-pushed
the
xml/instrChange
branch
from
d6b1fb6
to
5bad6ac
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2024
Backport of musescore#24932 and enable and fix testMultiInstrumentPart3. Also fixing some clang warnings.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 27, 2024
Backport of musescore#24932 and enable and fix testMultiInstrumentPart3. Also fixing some clazy warnings.
miiizen
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full export of instrument changes to MusicXML support.
Closes #17397.
NB: Import currently doesn't change the instrument name yet, so this has to be adjested for fully working round-trips of import and export.